chore: CP-8911 update packages #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vvava I tested and it works: I think we can close this PR like you said yesterday - there is another one in queue which updates to a higher version :) |
Looks great, thanks a lot! |
|
duplicated by #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had an issue with the tokens' price when a bridging tx was in progress. The price sometimes was 0.
Changes
The bridge config did not be loaded therefor it threw an error which was an empty object. Now we are waiting for the service to get the config before we want to get the data from there.
https://github.com/ava-labs/avalanche-sdks/pull/664
Testing
Try a bridging tx and check the price of the token.
Screenshots:
Checklist for the author
Tick each of them when done or if not applicable.